Re: [Qemu-devel] [PATCH for-2.8 v3 2/3] block/nfs: fix QMP to match debug option

[Eric Blake]

On 11/02/2016 11:50 AM, Prasanna Kumar Kalever wrote:
> The QMP definition of BlockdevOptionsNfs:
> { 'struct': 'BlockdevOptionsNfs',
>   'data': { 'server': 'NFSServer',
>             'path': 'str',
>             '*user': 'int',
>             '*group': 'int',
>             '*tcp-syn-count': 'int',
>             '*readahead-size': 'int',
>             '*page-cache-size': 'int',
>             '*debug-level': 'int' } }
> 
> To make this consistent with other block protocols like gluster, lets
> change s/debug-level/debug/
> 
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Prasanna Kumar Kalever <address@hidden>
> ---
>  block/nfs.c          | 4 ++--
>  qapi/block-core.json | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 

> +++ b/qapi/block-core.json
> @@ -2292,7 +2292,7 @@
>  # @page-cache-size:         #optional set the pagecache size in bytes 
> (defaults
>  #                           to libnfs default)
>  #
> -# @debug-level:             #optional set the NFS debug level (max 2) 
> (defaults
> +# @debug:                   #optional set the NFS debug level (max 2) 
> (defaults
>  #                           to libnfs default)
>  #
>  # Since 2.8

This is the first release of this struct. We WANT to avoid making future
name changes, as well as to avoid silly inconsistencies between
different drivers.  So this is definitely 2.8 material.

Apologies for not flagging this thread sooner as needing to go in to one
of the earlier release candidates.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature