Re: [Qemu-devel] [PATCH 2/3] Add a new qmp command to start/stop replication

[Zhang Chen]

On 12/01/2016 10:55 PM, Eric Blake wrote:
> On 12/01/2016 12:06 AM, Zhang Chen wrote:
> > We can call this qmp command to start/stop replication outside of qemu.
> > Like Xen colo need this function.
> >
> > Signed-off-by: Zhang Chen <address@hidden>
> > Signed-off-by: Wen Congyang <address@hidden>
> > ---
> > +++ b/qapi-schema.json
> > @@ -4676,6 +4676,24 @@
> >   { 'command': 'xen-load-devices-state', 'data': {'filename': 'str'} }
> >   
> >   ##
> > +# @xen-set-replication
> > +#
> > +# Enable or disable replication
> > +#
> > +# @enable: true to enable, false to disable.
> > +#
> > +# @primary: true for primary or false for secondary
> > +#
> > +# @failover: true to do failover, false to stop
> Missing an #optional marker, as well as the default value.

I will add this in next version.

> > +#
> > +# Returns: nothing
> > +#
> > +# Since: 2.8
> You've missed 2.8.  This must be 2.9.

good catch.

Thanks
Zhang Chen

> > +##
> > +{ 'command': 'xen-set-replication',
> > +  'data': { 'enable': 'bool', 'primary': 'bool', '*failover' : 'bool' } }
> > +
> > +##
> >   # @GICCapability:
> >   #
> >   # The struct describes capability for a specific GIC (Generic

--
Thanks
zhangchen