[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-timer: check active_timers outside lock/ev
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] qemu-timer: check active_timers outside lock/event |
|
Date: |
Thu, 1 Dec 2016 13:57:24 +0000 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Thu, Dec 01, 2016 at 10:03:43AM +0100, Paolo Bonzini wrote:
> This avoids taking the active_timers_lock or resetting/setting the
> timers_done_ev if there are no active timers. This removes a small
> (2-3%) source of overhead for dataplane. The list is then checked
> again inside the lock, or a NULL pointer could be dereferenced.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> qemu-timer.c | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature