[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [PATCH 2/4] 9pfs: introduce transport speci
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [Xen-devel] [PATCH 2/4] 9pfs: introduce transport specific callbacks |
Date: |
Mon, 28 Nov 2016 12:12:57 -0800 (PST) |
User-agent: |
Alpine 2.10 (DEB 1266 2009-07-14) |
On Thu, 24 Nov 2016, Greg Kurz wrote:
> On Thu, 24 Nov 2016 15:23:10 +0100
> Greg Kurz <address@hidden> wrote:
>
> > On Thu, 24 Nov 2016 09:31:52 +0100
> > Greg Kurz <address@hidden> wrote:
> >
> > > On Mon, 21 Nov 2016 13:39:30 -0800
> > > Stefano Stabellini <address@hidden> wrote:
> > >
> > > > Don't call virtio functions from 9pfs generic code, use generic function
> > > > callbacks instead.
> > > >
> > > > Signed-off-by: Stefano Stabellini <address@hidden>
> > > > ---
> > >
> > > Just a couple of indentation and line over 80 characters nits. I'll fix
> > > them
> > > before pushing to 9p-next.
> > >
> > > Reviewed-by: Greg Kurz <address@hidden>
> > >
> >
> > Hmm... second thought...
> >
>
> [...]
>
> > > > +
> > > > +static inline int v9fs_register_transport(V9fsState *s, struct
> > > > V9fsTransport *t)
> > > > +{
> > > > + if (s->transport) {
> > > > + return -EINVAL;
> > > > + }
>
> Calling v9fs_register_transport() several times for the same V9fsState looks
> more like a bug than an error...
Yes, you are right. I can turn this into an assert.
> also, is it possible to have several 9pfs
> shares with different transports ?
I think, at least theoretically, is possible. For example Xen HVM
guests, the ones most similar to KVM guests, already support virtio as a
transport. Additionally they will be able to support the Xen based
transport too. (Xen PV guests will only support
the Xen based transport as they don't support virtio in general.)
[Qemu-devel] [PATCH 3/4] 9pfs: use v9fs_init_qiov_from_pdu instead of v9fs_pack, Stefano Stabellini, 2016/11/21
[Qemu-devel] [PATCH 4/4] 9pfs: add a size parameter to init_iov_from_pdu, Stefano Stabellini, 2016/11/21
Re: [Qemu-devel] [PATCH 1/4] 9pfs: move pdus to V9fsState, Greg Kurz, 2016/11/24