[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ps2: add support for mice with extra/side butto
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] ps2: add support for mice with extra/side buttons |
Date: |
Mon, 28 Nov 2016 11:32:09 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/24/2016 07:16 AM, Fabian Lesniak wrote:
> This patch introduces the SIDE and EXTRA mouse buttons and implements
> appropriate event generation for gtk and input-linux input methods.
>
> The naming was borrowed from evdev since it is more descriptive than
> BUTTON4/5.
>
> Note that the guest has to switch the ps2 mouse into IMEX mode,
> otherwise events of the extra buttons are ignored. For example on a Windows
> guest one needs to manually select the "Microsoft PS/2 Mouse" driver.
>
> Signed-off-by: Fabian Lesniak <address@hidden>
> ---
> hw/input/ps2.c | 6 ++++++
> qapi-schema.json | 2 +-
> ui/gtk.c | 4 ++++
> ui/input-linux.c | 6 ++++++
> 4 files changed, 17 insertions(+), 1 deletion(-)
>
> +++ b/qapi-schema.json
> @@ -4280,7 +4280,7 @@
> # Since: 2.0
Please document the new enum members, including the fact that they are
'(since 2.9)'.
> ##
> { 'enum' : 'InputButton',
> - 'data' : [ 'left', 'middle', 'right', 'wheel-up', 'wheel-down' ] }
> + 'data' : [ 'left', 'middle', 'right', 'wheel-up', 'wheel-down',
> 'side', 'extra' ] }
Also, please keep this file under 80 columns.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature