[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] pcspk migration compatibility
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] pcspk migration compatibility |
Date: |
Mon, 28 Nov 2016 15:12:46 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
* Paolo Bonzini (address@hidden) wrote:
>
>
> On 28/11/2016 14:31, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > Hi,
> > 39c88f56 added VMState for pcspk but turned it on for
> > all machine types, this breaks backwards compatibility
> > to older machine types.
> >
> > If this is too late for 2.8 then I suggest we take the 1st
> > of these two patches, which just makes it a property to flip
> > for those of us who need it. Adding the 2nd patch after 2.8
> > might cause problems for people using 2.8 with 2.7 machine
> > type.
> >
> > Dave
> >
> > Dr. David Alan Gilbert (2):
> > migration/pcspk: Add a property to state if pcspk is migrated
> > migration/pcspk: Turn migration of pcspk off for 2.7 and older
> >
> > hw/audio/pcspk.c | 10 ++++++++++
> > include/hw/i386/pc.h | 5 +++++
> > 2 files changed, 15 insertions(+)
> >
>
> Wow, I didn't know optional sections existed. We could have used it for
> hw/char/parallel.c, but that was added only a couple months before
> optional sections.
I'd forgotten that they existed and was about to write them to
solve this problem, and then found the code I apparently reviewed
a year or so ago :-)
> Queued for 2.8.
Thanks.
Dave
> Paolo
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK