[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 05/15] tests: Add rules to non-gtester qtest test
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [RFC 05/15] tests: Add rules to non-gtester qtest test cases |
Date: |
Tue, 22 Nov 2016 11:34:42 -0200 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Mon, Nov 21, 2016 at 11:12:03PM -0200, Eduardo Habkost wrote:
[...]
> +define qtest-target =
This breaks on old GNU Make versions. Both patchew and travis-ci reported
similar errors:
make: *** No rule to make target `check-simpleqtest-x86_64', needed by
`check-simpleqtest'. Stop.
Old make versions don't seem to like the "=" operator after "define VAR".
Fixed by:
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 7016737..2799b16 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -808,7 +808,7 @@ SIMPLETEST_OPTIONS = $(if $(V),--verbose,--quiet)
# $(check-simpleqtest-$(ARCH)-y) automatically includes
# $(check-simpleqtest-generic-y)
-define qtest-target =
+define qtest-target
check-simpleqtest-$(1)-y += $$(check-simpleqtest-generic-y)
--
Eduardo
- [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines', Eduardo Habkost, 2016/11/21
- [Qemu-devel] [RFC 01/15] qemu.py: Make logging optional, Eduardo Habkost, 2016/11/21
- [Qemu-devel] [RFC 02/15] qtest.py: Support QTEST_LOG environment variable, Eduardo Habkost, 2016/11/21
- [Qemu-devel] [RFC 03/15] qtest.py: make logging optional, Eduardo Habkost, 2016/11/21
- [Qemu-devel] [RFC 04/15] qtest.py: Make 'binary' parameter optional, Eduardo Habkost, 2016/11/21
- [Qemu-devel] [RFC 05/15] tests: Add rules to non-gtester qtest test cases, Eduardo Habkost, 2016/11/21
- Re: [Qemu-devel] [RFC 05/15] tests: Add rules to non-gtester qtest test cases,
Eduardo Habkost <=
- [Qemu-devel] [RFC 06/15] qdev: Add device_type field to BusClass, Eduardo Habkost, 2016/11/21
- [Qemu-devel] [RFC 07/15] machine: Add MachineClass::default_buses field, Eduardo Habkost, 2016/11/21
- [Qemu-devel] [RFC 08/15] qmp: Add 'supported-device-types' field to 'query-machines', Eduardo Habkost, 2016/11/21
- [Qemu-devel] [RFC 10/15] pc: Initialize default bus lists, Eduardo Habkost, 2016/11/21
- [Qemu-devel] [RFC 09/15] pci: Introduce INTERFACE_PCIE_DEVICE interface name, Eduardo Habkost, 2016/11/21
- [Qemu-devel] [RFC 11/15] s390x: Initialize default bus lists, Eduardo Habkost, 2016/11/21
- [Qemu-devel] [RFC 13/15] mips: Initialize default bus lists, Eduardo Habkost, 2016/11/21
- [Qemu-devel] [RFC 14/15] ppc: Initialize default bus lists, Eduardo Habkost, 2016/11/21