Re: [Qemu-devel] [RFC PATCH] throttle: move throttling cmdline options to a separate header file

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [RFC PATCH] throttle: move throttling cmdline options to 
a separate header file
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
f5fd85c throttle: move throttling cmdline options to a separate header file

=== OUTPUT BEGIN ===
Checking PATCH 1/1: throttle: move throttling cmdline options to a separate 
header file...
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#133: FILE: include/qemu/throttle-options.h:14:
+#define THROTTLE_OPTS \
+        { \
+            .name = "throttling.iops-total", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "limit total I/O operations per second", \
+        },{ \
+            .name = "throttling.iops-read", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "limit read operations per second", \
+        },{ \
+            .name = "throttling.iops-write", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "limit write operations per second", \
+        },{ \
+            .name = "throttling.bps-total", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "limit total bytes per second", \
+        },{ \
+            .name = "throttling.bps-read", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "limit read bytes per second", \
+        },{ \
+            .name = "throttling.bps-write", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "limit write bytes per second", \
+        },{ \
+            .name = "throttling.iops-total-max", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "I/O operations burst", \
+        },{ \
+            .name = "throttling.iops-read-max", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "I/O operations read burst", \
+        },{ \
+            .name = "throttling.iops-write-max", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "I/O operations write burst", \
+        },{ \
+            .name = "throttling.bps-total-max", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "total bytes burst", \
+        },{ \
+            .name = "throttling.bps-read-max", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "total bytes read burst", \
+        },{ \
+            .name = "throttling.bps-write-max", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "total bytes write burst", \
+        },{ \
+            .name = "throttling.iops-total-max-length", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "length of the iops-total-max burst period, in seconds", \
+        },{ \
+            .name = "throttling.iops-read-max-length", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "length of the iops-read-max burst period, in seconds", \
+        },{ \
+            .name = "throttling.iops-write-max-length", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "length of the iops-write-max burst period, in seconds", \
+        },{ \
+            .name = "throttling.bps-total-max-length", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "length of the bps-total-max burst period, in seconds", \
+        },{ \
+            .name = "throttling.bps-read-max-length", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "length of the bps-read-max burst period, in seconds", \
+        },{ \
+            .name = "throttling.bps-write-max-length", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "length of the bps-write-max burst period, in seconds", \
+        },{ \
+            .name = "throttling.iops-size", \
+            .type = QEMU_OPT_NUMBER, \
+            .help = "when limiting by iops max size of an I/O in bytes", \
+        }

total: 1 errors, 0 warnings, 188 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden