Re: [Qemu-devel] [v2] tftp: fake support for netascii protocol

[hpa]

On November 21, 2016 7:35:28 AM PST, Vincent Bernat <address@hidden> wrote:
> ❦ 21 novembre 2016 14:46 GMT, Stefan Hajnoczi <address@hidden> :
>
>> The commit description says it would be "far more complex" to
>implement
>> netascii.  Is the LF -> CR LF and CR -> CR NUL transformation so
>hard?
>
>Currently, the code uses lseek to send each block. It is just a matter
>of doing nr_block*512. If there is a transformation, this cannot work
>this way. But this can be done, we'll just have to maintain an offset.
>
>Not knowing the final size is not a problem, just send back 0 as the
>size.

Incidentally, it would definitely be a good thing to  enable the blksize 
extension.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.