[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Bug 1643537] [NEW] target-ppc/int_helper.c: 2 * bad ar
From: |
joserz |
Subject: |
Re: [Qemu-devel] [Bug 1643537] [NEW] target-ppc/int_helper.c: 2 * bad array index |
Date: |
Mon, 21 Nov 2016 12:58:05 -0200 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Nov 21, 2016 at 02:23:25PM +0100, Thomas Huth wrote:
> On 21.11.2016 13:16, dcb wrote:
> > Public bug reported:
> >
> > 1.
> >
> > [qemu/target-ppc/int_helper.c:2575]: (error) Array 'reg.u16[8]' accessed
> > at index 8, which is out of bounds.
> >
> > Source code is
> >
> > return reg->u16[8 - n];
> >
> > and
> >
> > qemu/target-ppc/cpu.h: uint16_t u16[8];
> >
> > but at least once, n is zero, for example line 2725 in the int_helper.c
> > file:
> >
> > uint16_t sgnb = get_national_digit(b, 0);
>
> That looks wrong, indeed. I guess it should be "7 - n" instead of
> "8 - n"? Jose, could you please have a look at this?
>
> Thomas
>
Hello Thomas,
Just sent a patch to address it.
Thanks for letting me know it.
Ziviani