[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwrit
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwritev() |
Date: |
Fri, 18 Nov 2016 12:10:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 18/11/2016 10:51, Alberto Garcia wrote:
>
>>> >> Honestly I don't see the point. It seems easier, more practical and
>>> >> more effective to convert bdrv_aio_* to byte ranges, especially since
>>> >> QED would be basically a rewrite.
>> >
>> > Well, it's an RFC for a reason, I want people to give their opinions
>> > before consistently following through with this. But I do think that
>> > we pointlessly offer too many different interfaces to do the same
>> > thing in the block layer.
> I cannot speak much about the AIO/coroutine interfaces (why do we have
> both? is the latter supposed to supersede the former? I'd appreciate
> some background here) but I did find the code easier to follow after
> these patches, so from that point of view the series looks good to me.
If you like it, who am I to say no! :)
Paolo
- Re: [Qemu-devel] [RFC PATCH 7/8] quorum: Implement .bdrv_co_preadv/pwritev(), (continued)
[Qemu-devel] [RFC PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites, Kevin Wolf, 2016/11/10
Re: [Qemu-devel] [RFC PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwritev(), Paolo Bonzini, 2016/11/11
Re: [Qemu-devel] [RFC PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwritev(), no-reply, 2016/11/12