[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 1/4] qemu-char: add the "1-server-N-client"
From: |
Wei Wang |
Subject: |
Re: [Qemu-devel] [RFC PATCH 1/4] qemu-char: add the "1-server-N-client" support |
Date: |
Fri, 11 Nov 2016 16:28:58 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131028 Thunderbird/17.0.10 |
On 11/10/2016 07:38 PM, Marc-André Lureau wrote:
Hi
On Thu, Nov 10, 2016 at 6:47 AM Wei Wang <address@hidden
<mailto:address@hidden>> wrote:
This patch enables a qemu server socket to be connected by multiple
client sockets.
Thanks for sharing this early version of the series, I hope some early
feedback will help you. I'll be waiting for a more complete
implementation for detailed review.
Is this patch necessary as a first step? I would rather start with a
vhost-pci 1-1 Master-Slave series. Keep 1-n for a following
improvement. This would also probably post-pone the discussion
regarding connection-id, or uuid.
In short, I think it would help if you can break your proposal in
smaller independant steps.
OK, we can leave this QEMU socket patch to the 2nd step.
So, I think we can have a two-step plan:
Step1: 1-1 QEMU socket based vhost-pci-net design
Each QEMU socket manages (create/hotplug/destruction) only 1
vhost-pci-net device. To create more vhost-pci-net devices, the slave VM
needs to have more server sockets created at booting time.
Step2: 1-server-N-client based vhost-pci design
A single QEMU server socket manages all the vhost-pci devices (may
also in different device types).
Best,
Wei