Re: [Qemu-devel] [V6, 2/7] nios2: Add architecture emulation support

[Guenter Roeck]

On Tue, Oct 25, 2016 at 09:57:43PM +0200, Marek Vasut wrote:
> From: Chris Wulff <address@hidden>
> 
> Add support for emulating Altera NiosII R1 architecture into qemu.
> This patch is based on previous work by Chris Wulff from 2012 and
> updated to latest mainline QEMU.
> 
> Signed-off-by: Marek Vasut <address@hidden>
> Cc: Chris Wulff <address@hidden>
> Cc: Jeff Da Silva <address@hidden>
> Cc: Ley Foon Tan <address@hidden>
> Cc: Sandra Loosemore <address@hidden>
> Cc: Yves Vandervennet <address@hidden>
> ---
> V3: Thorough cleanup, deal with the review comments all over the place
> V4: - Use extract32()
>     - Fix gen_goto_tb() , suppress tcg_gen_goto_tb()
>     - Clean up gen_check_supervisor() helper
>     - Use TCGMemOp type for flags
>     - Drop jump labels from wrctl/rdctl
>     - More TCG cleanup
> V5: - Simplify load/store handling
>     - Handle loads into R_ZERO from protected page, add comment
> V6: - Fix division opcode handling
>     - Add missing disas handling
>     - V5 review comments cleanup
> ---
[ ... ]

> diff --git a/target-nios2/cpu.h b/target-nios2/cpu.h
> new file mode 100644
> index 0000000..17c9a0f
[ ... ]

> +static inline void cpu_get_tb_cpu_state(CPUNios2State *env, target_ulong *pc,
> +                                        target_ulong *cs_base, uint32_t 
> *flags)
> +{
> +    *pc = env->regs[R_PC];
> +    *cs_base = 0;
> +    *flags = (env->regs[CR_STATUS] & (CR_STATUS_EH | CR_STATUS_U));
> +}
> +
> +#endif /* CPU_NIOS2_H */
> +

The empty line at the end results in a whitespace message from git.

Guenter