Re: [Qemu-devel] [PATCH v2 2/2] virtio: make virtqueue_alloc_element static

[Cornelia Huck]

On Thu,  3 Nov 2016 09:55:50 +0100
Ladi Prosek <address@hidden> wrote:

> The function does not fully initialize the returned VirtQueueElement and 
> should
> be used only internally from the virtio module.
> 
> Signed-off-by: Ladi Prosek <address@hidden>
> ---
>  hw/virtio/virtio.c         | 2 +-
>  include/hw/virtio/virtio.h | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Cornelia Huck <address@hidden>

...although I'm wondering if the callers could not pass in the index
value as well? (Still keeping this internal to virtio.c makes sense.)