[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_l
|
From: |
Stefano Stabellini |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf() |
|
Date: |
Wed, 2 Nov 2016 10:34:12 -0700 (PDT) |
|
User-agent: |
Alpine 2.10 (DEB 1266 2009-07-14) |
On Wed, 2 Nov 2016, Thomas Huth wrote:
> Olaf Hering reported a build failure due to an undefined reference
> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
> fix the issue.
>
> Signed-off-by: Thomas Huth <address@hidden>
The fix makes sense:
Acked-by: Stefano Stabellini <address@hidden>
However I was unable to reproduce the build failure, so I would like a
confirmation from Olaf that the fix is working.
> hw/xen/xen_pvdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c
> index 405e154..5212bc6 100644
> --- a/hw/xen/xen_pvdev.c
> +++ b/hw/xen/xen_pvdev.c
> @@ -18,7 +18,7 @@
> */
>
> #include "qemu/osdep.h"
> -
> +#include "qemu/log.h"
> #include "hw/xen/xen_backend.h"
> #include "hw/xen/xen_pvdev.h"
>
> --
> 1.8.3.1
>