[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data |
Date: |
Wed, 2 Nov 2016 14:36:03 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 01.11.2016 um 04:16 hat John Snow geschrieben:
> v2:
> - Actually applied the changes this time ...
> - And added a test to the AHCI suite...
> - ...Which revealed a few small issues in the suite.
>
> The AHCI test should be sufficient in terms of general proof
> for ATAPI regardless of the HBA used.
As I commented, I think patch 3 includes a silent bug fix, so maybe
check whether you agree with my understanding of the code and consider
to make this more explicit. In any case, I think it's still correct:
Reviewed-by: Kevin Wolf <address@hidden>
- Re: [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data,
Kevin Wolf <=