[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/8] nvdimm acpi: use common macros instead of m
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 8/8] nvdimm acpi: use common macros instead of magic names |
Date: |
Tue, 1 Nov 2016 14:50:06 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Sat, Oct 29, 2016 at 12:11:56AM +0800, Xiao Guangrong wrote:
> /*
> * DSM notifier:
> - * NTFI: write the address of DSM memory and notify QEMU to emulate
> - * the access.
> + * NVDIMM_DSM_NOTIFY: write the address of DSM memory and notify QEMU to
> + * emulate the access.
Did you mean to search-replace this instance of "NTFI"?
> /*
> * DSM input:
> - * HDLE: store device's handle, it's zero if the _DSM call happens
> - * on NVDIMM Root Device.
> - * REVS: store the Arg1 of _DSM call.
> - * FUNC: store the Arg2 of _DSM call.
> - * FARG: store the Arg3 of _DSM call which is a Package containing
> - * function-specific arguments.
> + * NVDIMM_DSM_HANDLE: store device's handle, it's zero if the _DSM call
> + * happens on NVDIMM Root Device.
> + * NVDIMM_DSM_REVISION: store the Arg1 of _DSM call.
> + * NVDIMM_DSM_FUNCTION: store the Arg2 of _DSM call.
> + * NVDIMM_DSM_ARG3: store the Arg3 of _DSM call which is a Package
> + * containing function-specific arguments.
Did you mean to search-replace these names? I think it makes sense to
use the literal ACPI names instead of the macro names in documentation.
> /*
> * DSM output:
> - * RLEN: the size of the buffer filled by QEMU.
> - * ODAT: the buffer QEMU uses to store the result.
> + * NVDIMM_DSM_OUT_BUF_SIZE: the size of the buffer filled by QEMU.
> + * NVDIMM_DSM_OUT_BUF: the buffer QEMU uses to store the result.
Same here.
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 8/8] nvdimm acpi: use common macros instead of magic names,
Stefan Hajnoczi <=