Re: [Qemu-devel] [PULL for-2.8 00/15] target-sparc updates

[Peter Maydell]

On 31 October 2016 at 15:52, Richard Henderson <address@hidden> wrote:
> Mark requested that I send my own pull for my patch series.
>
>
> r~
>
>
> The following changes since commit 4178c782f85530d261058abdccc734aa9b7c89ca:
>
>   Merge remote-tracking branch 
> 'remotes/pmaydell/tags/pull-target-arm-20161028' into staging (2016-10-31 
> 11:12:02 +0000)
>
> are available in the git repository at:
>
>   git://github.com/rth7680/qemu.git tags/pull-sparc-20161031
>
> for you to fetch changes up to 24bf6eba1a656aa82519124e379122e61b1ee3bc:
>
>   target-sparc: Use tcg_gen_atomic_cmpxchg_tl (2016-10-31 09:46:25 -0600)
>
> ----------------------------------------------------------------
> target-sparc updates for atomics and alignment
>
> ----------------------------------------------------------------

I'm afraid this fails to build on windows:

In file included from /usr/share/mingw-w64/include/winsock2.h:54:0,
                 from
/home/petmay01/linaro/qemu-for-merges/include/sysemu/os-win32.h:29,
                 from
/home/petmay01/linaro/qemu-for-merges/include/qemu/osdep.h:100,
                 from
/home/petmay01/linaro/qemu-for-merges/target-sparc/translate.c:21:
/home/petmay01/linaro/qemu-for-merges/target-sparc/translate.c: In
function ‘gen_st_asi’:
/home/petmay01/linaro/qemu-for-merges/target-sparc/translate.c:2326:18:
error: expected ‘=’, ‘,’, ‘;’, ‘a
sm’ or ‘__attribute__’ before ‘.’ token
             TCGv s_addr = tcg_temp_new();
                  ^
/home/petmay01/linaro/qemu-for-merges/target-sparc/translate.c:2326:18:
error: expected expression before
 ‘.’ token
/home/petmay01/linaro/qemu-for-merges/target-sparc/translate.c:2332:29:
error: ‘S_un’ undeclared (first u
se in this function)
             tcg_gen_andi_tl(s_addr, src, -4);
                             ^
/home/petmay01/linaro/qemu-for-merges/target-sparc/translate.c:2332:29:
note: each undeclared identifier
is reported only once for each function it appears in
/home/petmay01/linaro/qemu-for-merges/rules.mak:60: recipe for target
'target-sparc/translate.o' failed
make[1]: *** [target-sparc/translate.o] Error 1
make[1]: *** Waiting for unfinished jobs....

Looks like your variable name clashes with a #define in
the windows headers :-(

/usr/share/mingw-w64/include/inaddr.h:#define s_addr    S_un.S_addr

thanks
-- PMM