[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses
From: |
Samuel Thibault |
Subject: |
Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses |
Date: |
Mon, 31 Oct 2016 13:01:59 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Cornelia Huck, on Mon 31 Oct 2016 12:45:30 +0100, wrote:
> > From: Samuel Thibault <address@hidden>
> >
> > Use ncursesw package instead of curses on non-mingw, and check a few
> > functions.
> > Also take cflags from pkg-config, since cursesw headers may be in a
> > separate, non-default directory.
> >
> > Signed-off-by: Samuel Thibault <address@hidden>
> > Message-id: address@hidden
> > Signed-off-by: Gerd Hoffmann <address@hidden>
> > ---
> > configure | 29 ++++++++++++++++++++---------
> > 1 file changed, 20 insertions(+), 9 deletions(-)
>
> This seems to break configure on one of the systems I use (which may or
> may not have a broken setup). SLES12SP1 (s390x) without curses in the
> output of pkg-config --list-all, but headers seem to be present (? --
> I'm not the admin). Other systems (Fedora and Ubuntu) are fine.
> config-temp/qemu-conf.c:9:3: warning: implicit declaration of function
> ‘addwstr’ [-Wimplicit-function-declaration]
Bleh.
Could you try to replace #include <curses.h> with #include <cursesw.h>
in ui/curses.c, to see whether that fixes the missing declaration on
that system? We could be trying both headers to look for the wide
functions and include the one which works.
Samuel
- [Qemu-devel] [PULL 0/6] ui patch queue., Gerd Hoffmann, 2016/10/28
- [Qemu-devel] [PULL 3/6] gtk: fix compilation warning with gtk 3.22.2, Gerd Hoffmann, 2016/10/28
- [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses, Gerd Hoffmann, 2016/10/28
- Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses, Cornelia Huck, 2016/10/31
- Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses,
Samuel Thibault <=
- Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses, Samuel Thibault, 2016/10/31
- Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses, Cornelia Huck, 2016/10/31
- Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses, Samuel Thibault, 2016/10/31
- Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses, Samuel Thibault, 2016/10/31
- Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses, Cornelia Huck, 2016/10/31
- Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses, Samuel Thibault, 2016/10/31
- Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses, Cornelia Huck, 2016/10/31
- Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses, Samuel Thibault, 2016/10/31
[Qemu-devel] [PULL 2/6] Defer BrlAPI tty acquisition to when guest starts using device, Gerd Hoffmann, 2016/10/28
[Qemu-devel] [PULL 5/6] curses: fix left/right arrow translation, Gerd Hoffmann, 2016/10/28