[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/8] slirp: VMStatify socket level
From: |
Samuel Thibault |
Subject: |
Re: [Qemu-devel] [PATCH 7/8] slirp: VMStatify socket level |
Date: |
Sun, 30 Oct 2016 15:47:12 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Hello,
Dr. David Alan Gilbert (git), on Thu 27 Oct 2016 16:32:16 +0100, wrote:
> - case AF_INET:
> - qemu_put_be32(f, so->so_faddr.s_addr);
> - qemu_put_be16(f, so->so_fport);
> - break;
> + if (version_id >= 4 && !is_inet) {
> + error_report("%s: so_ffamily unknown, socket not preserved",
> __func__);
> }
Well, no, we need to settle this another way, because we want to be able
to easily add inet6 support here. At least pave the way in a way that
makes it not unnecessarily hard. The code you are adding here looks to
me like very hard to rework to make it support the various socket
families.
> + VMSTATE_UINT16_V(so_ffamily, struct socket, 4),
> + VMSTATE_UINT32_TEST(so_faddr.s_addr, struct socket,
> + slirp_v4_or_newer_ffamily_inet),
> + VMSTATE_UINT16_TEST(so_fport, struct socket,
> + slirp_v4_or_newer_ffamily_inet),
Does VMStat not provide a way to have differing content depending on a
field? (here, so_ffamily)
Samuel
- [Qemu-devel] [PATCH 0/8] VMSTATE_WITH_TMP and it's use in SLIRP, Dr. David Alan Gilbert (git), 2016/10/27
- [Qemu-devel] [PATCH 2/8] add QEMU_BUILD_BUG_EXPR, Dr. David Alan Gilbert (git), 2016/10/27
- [Qemu-devel] [PATCH 4/8] tests/migration: Add test for VMSTATE_WITH_TMP, Dr. David Alan Gilbert (git), 2016/10/27
- [Qemu-devel] [PATCH 3/8] migration: Add VMSTATE_WITH_TMP, Dr. David Alan Gilbert (git), 2016/10/27
- [Qemu-devel] [PATCH 1/8] migration: extend VMStateInfo, Dr. David Alan Gilbert (git), 2016/10/27
- [Qemu-devel] [PATCH 8/8] slirp: VMStatify remaining except for loop, Dr. David Alan Gilbert (git), 2016/10/27
- [Qemu-devel] [PATCH 5/8] slirp: VMState conversion; tcpcb, Dr. David Alan Gilbert (git), 2016/10/27
- [Qemu-devel] [PATCH 7/8] slirp: VMStatify socket level, Dr. David Alan Gilbert (git), 2016/10/27
- Re: [Qemu-devel] [PATCH 7/8] slirp: VMStatify socket level,
Samuel Thibault <=
- [Qemu-devel] [PATCH 6/8] slirp: VMStatify sbuf, Dr. David Alan Gilbert (git), 2016/10/27