Re: [Qemu-devel] [PATCH v2 2/6] bitops: fix rol/ror when shift is zero

[Nikunj A Dadhania]

David Gibson <address@hidden> writes:

> [ Unknown signature status ]
> On Wed, Oct 26, 2016 at 08:20:10AM -0700, Richard Henderson wrote:
>> On 10/25/2016 11:26 PM, Nikunj A Dadhania wrote:
>> > All the variants for rol/ror have a bug in case where the shift == 0.
>> > For example rol32, would generate:
>> > 
>> >     return (word << 0) | (word >> 32);
>> > 
>> > Which though works, would be flagged as a runtime error on clang's
>> > sanitizer.
>> > 
>> > Suggested-by: Richard Henderson <address@hidden>
>> > Signed-off-by: Nikunj A Dadhania <address@hidden>
>> > ---
>> >  include/qemu/bitops.h | 16 ++++++++--------
>> >  1 file changed, 8 insertions(+), 8 deletions(-)
>> 
>> Reviewed-by: Richard Henderson <address@hidden>
>
> This looks fine to me too, but I'm not sure if it should be going via
> my tree or not.

get_maintainer.pl does not help either.

Regards
Nikunj