[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/9] i.MX: Fix GPIO ISR register write
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PULL 1/9] i.MX: Fix GPIO ISR register write |
Date: |
Fri, 28 Oct 2016 15:59:16 +0100 |
From: Guenter Roeck <address@hidden>
Writing the ISR register is supposed to clear interrupt status bits,
not to set them.
This patch makes '-M sabrelite' work without devicetree changes (Linux
kernel versions 3.18 to 4.7 with imx_v6_v7_defconfig and up to v4.8 with
multi_v7_defconfig; mainline has different problems).
Signed-off-by: Guenter Roeck <address@hidden>
Message-id: address@hidden
Acked-by: Jean-Christophe Dubois <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
---
hw/gpio/imx_gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gpio.c
index f3574aa..c36c394 100644
--- a/hw/gpio/imx_gpio.c
+++ b/hw/gpio/imx_gpio.c
@@ -237,7 +237,7 @@ static void imx_gpio_write(void *opaque, hwaddr offset,
uint64_t value,
break;
case ISR_ADDR:
- s->isr |= ~value;
+ s->isr &= ~value;
imx_gpio_set_all_int_lines(s);
break;
--
2.7.4
- [Qemu-devel] [PULL 0/9] target-arm queue, Peter Maydell, 2016/10/28
- [Qemu-devel] [PULL 8/9] hw/arm/spitz: Fix reset handling, Peter Maydell, 2016/10/28
- [Qemu-devel] [PULL 7/9] arm: virt: add PMU property to mach-virt machine type, Peter Maydell, 2016/10/28
- [Qemu-devel] [PULL 3/9] hw/arm/pxa2xx: Set value default values for CCCR and CKEN on PXA255, Peter Maydell, 2016/10/28
- [Qemu-devel] [PULL 9/9] hw/arm/tosa: Fix reset handling, Peter Maydell, 2016/10/28
- [Qemu-devel] [PULL 5/9] char: cadence: correct reset value for baud rate registers, Peter Maydell, 2016/10/28
- [Qemu-devel] [PULL 4/9] versatilepb: do not run if user asks for more than 256MB RAM, Peter Maydell, 2016/10/28
- [Qemu-devel] [PULL 6/9] arm: Add an option to turn on/off vPMU support, Peter Maydell, 2016/10/28
- [Qemu-devel] [PULL 1/9] i.MX: Fix GPIO ISR register write,
Peter Maydell <=
- [Qemu-devel] [PULL 2/9] arm: cubieboard: Add support for initrd, Peter Maydell, 2016/10/28
- Re: [Qemu-devel] [PULL 0/9] target-arm queue, Peter Maydell, 2016/10/31