Re: [Qemu-devel] [PATCH v2] trace: Fix 'char **' compilation error in simple backend

[Peter Maydell]

On 26 October 2016 at 14:18, Eric Blake <address@hidden> wrote:
> On 10/25/2016 10:50 PM, Fam Zheng wrote:
>> Currently, the generated function body will do "strlen(arg)" but the
>> argument could be 'char **' or 'char * const *'. Avoid that by excluding
>> such cases in is_string check.
>>
>> Reported by patchew's "make address@hidden".
>>
>> Suggested-by: Eric Blake <address@hidden>
>> Signed-off-by: Fam Zheng <address@hidden>
>>
>> ---
>>
>> v2: Fix typo in commit message and "yeah we'll be counting stars".  [Eric]
>
> I may have had the vague idea, but you eloquently framed it into code,
> and let me learn in the process :)
>
> Reviewed-by: Eric Blake <address@hidden>

Applied to master as a buildfix, thanks (though it looks like there
is also a trace related compile failure for the UST backend,
so this alone won't be enough to bring travis back to all-green).

-- PMM