[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 22/37] target-i386: emulate LOCK'ed NOT using atom
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL v2 22/37] target-i386: emulate LOCK'ed NOT using atomic helper |
Date: |
Wed, 26 Oct 2016 09:15:48 -0700 |
From: "Emilio G. Cota" <address@hidden>
[rth: Avoid qemu_load that's redundant with the atomic op.]
Signed-off-by: Emilio G. Cota <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target-i386/translate.c | 26 ++++++++++++++++++++------
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 2f39dac..6d71564 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -4674,10 +4674,15 @@ static target_ulong disas_insn(CPUX86State *env,
DisasContext *s,
rm = (modrm & 7) | REX_B(s);
op = (modrm >> 3) & 7;
if (mod != 3) {
- if (op == 0)
+ if (op == 0) {
s->rip_offset = insn_const_size(ot);
+ }
gen_lea_modrm(env, s, modrm);
- gen_op_ld_v(s, ot, cpu_T0, cpu_A0);
+ /* For those below that handle locked memory, don't load here. */
+ if (!(s->prefix & PREFIX_LOCK)
+ || op != 2) {
+ gen_op_ld_v(s, ot, cpu_T0, cpu_A0);
+ }
} else {
gen_op_mov_v_reg(ot, cpu_T0, rm);
}
@@ -4690,11 +4695,20 @@ static target_ulong disas_insn(CPUX86State *env,
DisasContext *s,
set_cc_op(s, CC_OP_LOGICB + ot);
break;
case 2: /* not */
- tcg_gen_not_tl(cpu_T0, cpu_T0);
- if (mod != 3) {
- gen_op_st_v(s, ot, cpu_T0, cpu_A0);
+ if (s->prefix & PREFIX_LOCK) {
+ if (mod == 3) {
+ goto illegal_op;
+ }
+ tcg_gen_movi_tl(cpu_T0, ~0);
+ tcg_gen_atomic_xor_fetch_tl(cpu_T0, cpu_A0, cpu_T0,
+ s->mem_index, ot | MO_LE);
} else {
- gen_op_mov_reg_v(ot, rm, cpu_T0);
+ tcg_gen_not_tl(cpu_T0, cpu_T0);
+ if (mod != 3) {
+ gen_op_st_v(s, ot, cpu_T0, cpu_A0);
+ } else {
+ gen_op_mov_reg_v(ot, rm, cpu_T0);
+ }
}
break;
case 3: /* neg */
--
2.7.4
- [Qemu-devel] [PULL v2 06/37] int128: Use __int128 if available, (continued)
- [Qemu-devel] [PULL v2 06/37] int128: Use __int128 if available, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 10/37] cputlb: Replace SHIFT with DATA_SIZE, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 14/37] cputlb: Tidy some macros, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 12/37] cputlb: Remove includes from softmmu_template.h, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 13/37] cputlb: Move most of iotlb code out of line, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 11/37] cputlb: Move probe_write out of softmmu_template.h, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 18/37] tcg: Emit barriers with parallel_cpus, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 17/37] tcg: Add CONFIG_ATOMIC64, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 15/37] tcg: Add atomic helpers, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 19/37] target-i386: emulate LOCK'ed cmpxchg using cmpxchg helpers, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 22/37] target-i386: emulate LOCK'ed NOT using atomic helper,
Richard Henderson <=
- [Qemu-devel] [PULL v2 20/37] target-i386: emulate LOCK'ed OP instructions using atomic helpers, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 16/37] tcg: Add atomic128 helpers, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 21/37] target-i386: emulate LOCK'ed INC using atomic helper, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 24/37] target-i386: emulate LOCK'ed XADD using atomic helper, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 26/37] target-i386: emulate XCHG using atomic helper, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 23/37] target-i386: emulate LOCK'ed NEG using cmpxchg helper, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 25/37] target-i386: emulate LOCK'ed BTX ops using atomic helpers, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 28/37] tests: add atomic_add-bench, Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 27/37] target-i386: remove helper_lock(), Richard Henderson, 2016/10/26
- [Qemu-devel] [PULL v2 29/37] target-arm: Rearrange aa32 load and store functions, Richard Henderson, 2016/10/26