qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 14/17] COLO: Implement the


From: Amit Shah
Subject: Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 14/17] COLO: Implement the process of failover for primary VM
Date: Wed, 26 Oct 2016 11:28:10 +0530

On (Tue) 18 Oct 2016 [20:10:10], zhanghailiang wrote:
> For primary side, if COLO gets failover request from users.
> To be exact, gets 'x_colo_lost_heartbeat' command.
> COLO thread will exit the loop while the failover BH does the
> cleanup work and resumes VM.
> 
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Li Zhijian <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>


> @@ -162,9 +196,20 @@ static int colo_do_checkpoint_transaction(MigrationState 
> *s,

> @@ -280,8 +330,6 @@ out:
>      if (local_err) {
>          error_report_err(local_err);
>      }
> -    migrate_set_state(&s->state, MIGRATION_STATUS_COLO,
> -                      MIGRATION_STATUS_COMPLETED);

Yea, I guess this should not have been done in the previous patch to
begin with?

                Amit



reply via email to

[Prev in Thread] Current Thread [Next in Thread]