Re: [Qemu-devel] [PATCH] tests: Remove unneeded "-vnc none" option

[John Snow]

On 10/24/2016 12:25 PM, Eduardo Habkost wrote:
> Some tests use the "-vnc none" option without any clear reason,
> making those tests break when --disable-vnc is specified on
> ./configure.  Remove the unnecessary option.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  tests/ide-test.c      | 1 -
>  tests/ipmi-bt-test.c  | 2 +-
>  tests/ipmi-kcs-test.c | 2 +-
>  3 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tests/ide-test.c b/tests/ide-test.c
> index a8a4081..3fbcb75 100644
> --- a/tests/ide-test.c
> +++ b/tests/ide-test.c
> @@ -582,7 +582,6 @@ static void test_retry_flush(const char *machine)
>      prepare_blkdebug_script(debug_path, "flush_to_disk");
>
>      ide_test_start(
> -        "-vnc none "
>          "-drive file=blkdebug:%s:%s,if=ide,cache=writeback,format=raw,"
>          "rerror=stop,werror=stop",
>          debug_path, tmp_path);

Reviewed-by: John Snow <address@hidden>

> diff --git a/tests/ipmi-bt-test.c b/tests/ipmi-bt-test.c
> index be9005e..ad1e97e 100644
> --- a/tests/ipmi-bt-test.c
> +++ b/tests/ipmi-bt-test.c
> @@ -415,7 +415,7 @@ int main(int argc, char **argv)
>      /* Run the tests */
>      g_test_init(&argc, &argv, NULL);
>
> -    cmdline = g_strdup_printf("-vnc none"
> +    cmdline = g_strdup_printf(
>            " -chardev socket,id=ipmi0,host=localhost,port=%d,reconnect=10"
>            " -device ipmi-bmc-extern,chardev=ipmi0,id=bmc0"
>            " -device isa-ipmi-bt,bmc=bmc0", emu_port);
> diff --git a/tests/ipmi-kcs-test.c b/tests/ipmi-kcs-test.c
> index 3750389..9cf0b34 100644
> --- a/tests/ipmi-kcs-test.c
> +++ b/tests/ipmi-kcs-test.c
> @@ -276,7 +276,7 @@ int main(int argc, char **argv)
>      /* Run the tests */
>      g_test_init(&argc, &argv, NULL);
>
> -    cmdline = g_strdup_printf("-vnc none -device ipmi-bmc-sim,id=bmc0"
> +    cmdline = g_strdup_printf("-device ipmi-bmc-sim,id=bmc0"
>                                " -device isa-ipmi-kcs,bmc=bmc0");
>      qtest_start(cmdline);
>      qtest_irq_intercept_in(global_qtest, "ioapic");