|
From: | Xiao Guangrong |
Subject: | Re: [Qemu-devel] [PATCH] acpi: fix assert failure caused by commit 35c5a52d |
Date: | Mon, 24 Oct 2016 17:46:13 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 10/19/2016 05:19 PM, Haozhong Zhang wrote:
Commit 35c5a52d "acpi: do not use TARGET_PAGE_SIZE" changed struct NvdimmDsmIn from a variable-size structure to a fixed-size structure of 4096 bytes. It forgot to adjust an assert in nvdimm_dsm_set_label_data(..., NvdimmDsmIn *in, ...): assert(sizeof(*in) + sizeof(*set_label_data) + set_label_data->length <= 4096); which could crash QEMU when guest writes NVDIMM labels. Fix it by replacing sizeof(*in) by offsetof(NvdimmDsmIn, arg3).
Thanks for your fix. Reviewed-by: Xiao Guangrong <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |