|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH V5 2/7] nios2: Add architecture emulation support |
Date: | Sat, 22 Oct 2016 21:20:39 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 10/22/2016 08:01 PM, Marek Vasut wrote:
For signed division, you have to protect against 0x80000000 / -1 as well, which raises an overflow exception on the x86 host.You mean similar to what mips does on OPC_DIV vs OPC_DIVU , right ?
Yes.
No CPU_LOG_TB_IN_ASM disassembly? I thought patch 1 added a nios2 disassembler.Nope, I removed it in V4, maybe i misunderstood the review comment? "+ /* Dump the CPU state to the log */ + if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)) { + qemu_log("--------------\n"); + log_cpu_state(cs, 0); + }Cpu state is dumped by -d cpu generically. "
CPU state != disassembly. I mean if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) && qemu_log_in_addr_range(pc_start)) { qemu_log("IN: %s\n", lookup_symbol(pc_start)); log_target_disas(cs, pc_start, ctx.pc - pc_start, 1); qemu_log("\n"); } r~
[Prev in Thread] | Current Thread | [Next in Thread] |