[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] raw_bsd: add offset and size options
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v3] raw_bsd: add offset and size options |
Date: |
Wed, 19 Oct 2016 05:00:41 -0700 (PDT) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v3] raw_bsd: add offset and size options
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
aa8070a raw_bsd: add offset and size options
=== OUTPUT BEGIN ===
Checking PATCH 1/1: raw_bsd: add offset and size options...
ERROR: externs should be avoided in .c files
#103: FILE: block/raw_bsd.c:116:
+ error_setg here(errp, "Specified size is not multiple of %llu!",
ERROR: space prohibited before that close parenthesis ')'
#241: FILE: block/raw_bsd.c:312:
+ if (INT64_MAX - offset < s->offset ) {
total: 2 errors, 0 warnings, 275 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden