Re: [Qemu-devel] [V5 1/6] hw/msi: Allow platform devices to use explicit SID

[David Kiarie]

On Mon, Oct 10, 2016 at 11:34 AM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 10/10/2016 00:11, Michael S. Tsirkin wrote:
>> On Tue, Sep 20, 2016 at 08:40:41PM +0300, David Kiarie wrote:
>>> When using IOMMU platform devices like IOAPIC are required to make
>>> interrupt remapping requests using explicit SID. We associate an MSI
>>> route with a requester ID and a PCI device if present which ensures
>>> that platform devices can call IOMMU interrupt remapping code with
>>> explicit SID. This also ensures compatility with the original code
>>> which mainly dealt with PCI devices.
>>>
>>> Signed-off-by: David Kiarie <address@hidden>
>>
>> Paolo, could you please ack the kvm changes?
>
> Acked-by: Paolo Bonzini <address@hidden>
>
>> Thanks!

Thanks for the feedback. Something since to have changed recently
though that these patches seems to introduce a bug. I'm yet to fix
track/fix it. Will resend these as soon as I get around it.

>>
>>> ---
>>>  hw/i386/intel_iommu.c             |  3 +++
>>>  hw/i386/kvm/pci-assign.c          | 12 ++++++++----
>>>  hw/intc/ioapic.c                  | 33 ++++++++++++++++++++++++++-------
>>>  hw/misc/ivshmem.c                 |  6 ++++--
>>>  hw/vfio/pci.c                     |  6 ++++--
>>>  hw/virtio/virtio-pci.c            |  7 +++++--
>>>  include/hw/i386/ioapic_internal.h |  1 +
>>>  include/hw/i386/x86-iommu.h       |  1 +
>>>  include/sysemu/kvm.h              | 25 ++++++++++++++-----------
>>>  kvm-all.c                         | 11 +++++++----
>>>  kvm-stub.c                        |  5 +++--
>>>  target-arm/kvm.c                  |  3 ++-
>>>  target-i386/kvm.c                 | 15 +++++++++------
>>>  target-mips/kvm.c                 |  3 ++-
>>>  target-ppc/kvm.c                  |  3 ++-
>>>  target-s390x/kvm.c                |  3 ++-
>>>  16 files changed, 93 insertions(+), 44 deletions(-)
>>>
>
>>> --
>>> 2.1.4