[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qapi: fix memory leak in bdrv_image_info_specif
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH] qapi: fix memory leak in bdrv_image_info_specific_dump |
|
Date: |
Tue, 18 Oct 2016 11:44:26 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 18.10.2016 um 11:18 hat Pino Toscano geschrieben:
> The 'obj' result of the visitor was not properly freed, like done in
> other places doing a similar job.
> ---
> block/qapi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/qapi.c b/block/qapi.c
> index 6f947e3..50d3090 100644
> --- a/block/qapi.c
> +++ b/block/qapi.c
> @@ -698,6 +698,7 @@ void bdrv_image_info_specific_dump(fprintf_function
> func_fprintf, void *f,
> assert(qobject_type(obj) == QTYPE_QDICT);
> data = qdict_get(qobject_to_qdict(obj), "data");
> dump_qobject(func_fprintf, f, 1, data);
> + qobject_decref(obj);
> visit_free(v);
> }
The change looks good, but without a Signed-off-by line I can't accept
the patch: http://wiki.qemu.org/Contribute/SubmitAPatch
Kevin