[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] migrate: Share common MigrationParameters s
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] migrate: Share common MigrationParameters struct |
Date: |
Mon, 17 Oct 2016 16:31:54 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/08/2016 10:14 PM, Eric Blake wrote:
> It is rather verbose, and slightly error-prone, to repeat
> the same set of parameters for input (migrate-set-parameters)
> as for output (query-migrate-parameters), where the only
> difference is whether the members are optional. We can just
> document that the optional members will always be present
> on output, and then share a common struct between both
> commands. The next patch can then reduce the amount of
> code needed on input.
> '*tls-hostname': 'str'} }
> -
> -#
> -# @MigrationParameters
> -#
...
> -##
> -{ 'struct': 'MigrationParameters',
> - 'data': { 'compress-level': 'int',
> - 'compress-threads': 'int',
> - 'decompress-threads': 'int',
> - 'cpu-throttle-initial': 'int',
> - 'cpu-throttle-increment': 'int',
> - 'tls-creds': 'str',
> - 'tls-hostname': 'str'} }
> ##
> # @query-migrate-parameters
Pre-existing - there was no blank line before the docs for
query-migrate-parameters. Commit a43edcf fixed the blank line, then the
merge conflict resolution undid things; so I've submitted a followup.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature