Re: [Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

[Vladimir Sementsov-Ogievskiy]

On 07.10.2016 22:24, Max Reitz wrote:
> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
> > Realize block bitmap stroing interface, to allow qcow2 images store
> > persistent bitmaps.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > ---
> >   block/qcow2-bitmap.c | 241 +++++++++++++++++++++++++++++++++++++++++++++++++++

[...]

> > +        ret = bdrv_pwrite(bs->file, off, buf, cl_size);
> > +        if (ret < 0) {
> > +            goto finish;
> > +        }
> > +
> > +        if (end >= bm_size) {
> > +            break;
> > +        }
> > +
> > +        bdrv_set_dirty_iter(dbi, end);
> > +    }
> > +    ret = 0; /* writes */
> What is that comment supposed to mean?

Now I think I can drop this assignment, as bdrv_aligned_preadv have 
'return ret < 0 ? ret : 0;' in the end...  Am I right? Can bdrv_pwrite 
and friends return positive value on success?

--
Best regards,
Vladimir