[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init()
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init() |
Date: |
Fri, 14 Oct 2016 16:26:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 14/10/2016 16:13, Laurent Vivier wrote:
>
>
> On 14/10/2016 16:11, Igor Mammedov wrote:
>> On Thu, 13 Oct 2016 18:24:43 +0200
>> Laurent Vivier <address@hidden> wrote:
>>
>>> Extract the realize part to cpu_exec_realize(), update all
>>> calls to cpu_exec_init() to add cpu_exec_realize() to
>>> have no functionnal change.
>>>
>>> Put in cpu_exec_init() what initializes the CPU,
>>> in cpu_exec_realize() what adds it to the environment.
>> now since it's split, why not call cpu_exec_init()
>> from common cpu_common_initfn() and do
>> s/cpu_exec_init/cpu_exec_realize/ on individual targets
>> so that they don't have to call it from their _initfn()s.
>
> It's done later in the series.
But I'm going to simplified the series as proposed by you and Eduardo.
Thanks,
Laurent
[Qemu-devel] [PATCH v2 03/20] target-ppc: move back cpu_exec_init() to init, Laurent Vivier, 2016/10/13