[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 12/20] target-moxie: move cpu_exec_realize() to r
From: |
Laurent Vivier |
Subject: |
[Qemu-devel] [PATCH v2 12/20] target-moxie: move cpu_exec_realize() to realize function |
Date: |
Thu, 13 Oct 2016 18:24:54 +0200 |
I've removed the cannot_destroy_with_object_finalize_yet field as
unsafe references have been moved to cpu_exec_realize().
(tested with QOM command provided by commit 4c315c27 with
"moxie-cpu")
CC: Anthony Green <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
target-moxie/cpu.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/target-moxie/cpu.c b/target-moxie/cpu.c
index c9eed19..a4003aa 100644
--- a/target-moxie/cpu.c
+++ b/target-moxie/cpu.c
@@ -61,6 +61,13 @@ static void moxie_cpu_realizefn(DeviceState *dev, Error
**errp)
{
CPUState *cs = CPU(dev);
MoxieCPUClass *mcc = MOXIE_CPU_GET_CLASS(dev);
+ Error *local_err = NULL;
+
+ cpu_exec_realize(cs, &local_err);
+ if (local_err != NULL) {
+ error_propagate(errp, local_err);
+ return;
+ }
qemu_init_vcpu(cs);
cpu_reset(cs);
@@ -76,7 +83,6 @@ static void moxie_cpu_initfn(Object *obj)
cs->env_ptr = &cpu->env;
cpu_exec_init(cs);
- cpu_exec_realize(cs, &error_abort);
if (tcg_enabled() && !inited) {
inited = 1;
@@ -125,13 +131,6 @@ static void moxie_cpu_class_init(ObjectClass *oc, void
*data)
cc->vmsd = &vmstate_moxie_cpu;
#endif
cc->disas_set_info = moxie_cpu_disas_set_info;
-
- /*
- * Reason: moxie_cpu_initfn() calls cpu_exec_init(), which saves
- * the object in cpus -> dangling pointer after final
- * object_unref().
- */
- dc->cannot_destroy_with_object_finalize_yet = true;
}
static void moxielite_initfn(Object *obj)
--
2.7.4
- [Qemu-devel] [PATCH v2 02/20] target-i386: move back cpu_exec_init() to init, (continued)
- [Qemu-devel] [PATCH v2 02/20] target-i386: move back cpu_exec_init() to init, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 03/20] target-ppc: move back cpu_exec_init() to init, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 04/20] target-s390: move back cpu_exec_init() to init, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 07/20] target-cris: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 06/20] target-alpha: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 05/20] target-arm: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 08/20] target-lm32: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 09/20] target-m68k: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 10/20] target-microblaze: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 11/20] target-mips: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 12/20] target-moxie: move cpu_exec_realize() to realize function,
Laurent Vivier <=
- [Qemu-devel] [PATCH v2 13/20] target-openrisc: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 14/20] target-sh4: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 15/20] target-sparc: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 16/20] target-tilegx: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 17/20] target-tricore: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 18/20] target-unicore32: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 19/20] target-xtensa: move cpu_exec_realize() to realize function, Laurent Vivier, 2016/10/13
- [Qemu-devel] [PATCH v2 20/20] exec: move cpu_exec_init() to cpu_common_initfn(), Laurent Vivier, 2016/10/13