[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 19/20] trace: introduce a formal group name fo
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL v2 19/20] trace: introduce a formal group name for trace events |
Date: |
Thu, 13 Oct 2016 15:58:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 12/10/2016 10:47, Stefan Hajnoczi wrote:
> +def make_group_name(filename):
> + dirname = os.path.realpath(os.path.dirname(filename))
> + basedir = os.path.join(os.path.dirname(__file__), os.pardir)
> + basedir = os.path.realpath(os.path.abspath(basedir))
> + dirname = dirname[len(basedir) + 1:]
> +
> + if dirname == "":
> + return "common"
> + return re.sub(r"/|-", "_", dirname)
>
The group is based on the build directory, so it includes the relative
path from srcdir to builddir. My build directory is weird ("+build")
and breaks because of this. Since the group is not really used for
anything yet, perhaps this patch could be reverted?
Paolo
- [Qemu-devel] [PULL v2 11/20] trace: don't abort qemu if ftrace can't be initialized, (continued)
- [Qemu-devel] [PULL v2 11/20] trace: don't abort qemu if ftrace can't be initialized, Stefan Hajnoczi, 2016/10/12
- [Qemu-devel] [PULL v2 12/20] trace: provide mechanism for registering trace events, Stefan Hajnoczi, 2016/10/12
- [Qemu-devel] [PULL v2 13/20] trace: dynamically allocate trace_dstate in CPUState, Stefan Hajnoczi, 2016/10/12
- [Qemu-devel] [PULL v2 14/20] trace: dynamically allocate event IDs at runtime, Stefan Hajnoczi, 2016/10/12
- [Qemu-devel] [PULL v2 15/20] trace: get rid of generated-events.h/generated-events.c, Stefan Hajnoczi, 2016/10/12
- [Qemu-devel] [PULL v2 16/20] trace: rename _read_events to read_events, Stefan Hajnoczi, 2016/10/12
- [Qemu-devel] [PULL v2 17/20] trace: push reading of events up a level to tracetool main, Stefan Hajnoczi, 2016/10/12
- [Qemu-devel] [PULL v2 18/20] trace: pass trace-events to tracetool as a positional param, Stefan Hajnoczi, 2016/10/12
- [Qemu-devel] [PULL v2 20/20] trace: Add missing execution mode of guest events, Stefan Hajnoczi, 2016/10/12
- [Qemu-devel] [PULL v2 19/20] trace: introduce a formal group name for trace events, Stefan Hajnoczi, 2016/10/12
- Re: [Qemu-devel] [PULL v2 19/20] trace: introduce a formal group name for trace events,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL v2 00/20] Tracing patches, Peter Maydell, 2016/10/12