Re: [Qemu-devel] [PATCH v3 14/13] pc: q35: bump max_cpus to 288

[Radim Krčmář]

2016-10-13 15:24+0200, Igor Mammedov:
> along with it for machine versions 2.7 and older keep
> it at 255.
> 
> Signed-off-by: Igor Mammedov <address@hidden>
> ---

Seems nicer than touching max_cpus in pc_machine_class_init(),

Reviewed-by: Radim Krčmář <address@hidden>

> Forgot to inlude the last patch that
> permits using more than 255 cpus since q35-2.8 machine type
> 
> 
> v2:
>  - make 288 cpus available only since q35-2.8 machine type
> ---
>  hw/i386/pc_q35.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index 0b214f2..b40d19e 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -291,6 +291,7 @@ static void pc_q35_machine_options(MachineClass *m)
>      m->default_display = "std";
>      m->no_floppy = 1;
>      m->has_dynamic_sysbus = true;
> +    m->max_cpus = 288;
>  }
>  
>  static void pc_q35_2_8_machine_options(MachineClass *m)
> @@ -306,6 +307,7 @@ static void pc_q35_2_7_machine_options(MachineClass *m)
>  {
>      pc_q35_2_8_machine_options(m);
>      m->alias = NULL;
> +    m->max_cpus = 255;
>      SET_MACHINE_COMPAT(m, PC_COMPAT_2_7);
>  }
>  
> -- 
> 2.7.4
> 
>