[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/10] ui: remove bogus call to graphic_hw_update() i
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 06/10] ui: remove bogus call to graphic_hw_update() in vnc_listen_io |
Date: |
Thu, 13 Oct 2016 11:32:54 +0200 |
From: "Daniel P. Berrange" <address@hidden>
Just before accepting a new client connection the vnc_listen_io
method calls graphic_hw_update(). This is bogus because there
is a call to this method already in vnc_state_init() and the
client doesn't need up2date graphics console before reaching
that.
Signed-off-by: Daniel P. Berrange <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/vnc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 2f3ebdc..d1f33d3 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3102,8 +3102,6 @@ static gboolean vnc_listen_io(QIOChannel *ioc,
QIOChannelSocket *sioc = NULL;
Error *err = NULL;
- /* Catch-up */
- graphic_hw_update(vd->dcl.con);
sioc = qio_channel_socket_accept(QIO_CHANNEL_SOCKET(ioc), &err);
if (sioc != NULL) {
qio_channel_set_delay(QIO_CHANNEL(sioc), false);
--
1.8.3.1
- [Qemu-devel] [PULL 00/10] ui: vnc cleanups, input-linux kbd fix., Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 01/10] ui: remove misleading comment from vnc_init_state, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 07/10] ui: remove bogus call to reset_keys() in vnc_init_state, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 10/10] input-linux: initialize key state, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 03/10] ui: remove 'ws_tls' field from VncState, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 04/10] ui: rename misleading 'VncDisplay' variables, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 06/10] ui: remove bogus call to graphic_hw_update() in vnc_listen_io,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 05/10] ui: refactor method for setting up VncDisplay auth types, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 08/10] ui: move some initialization out of vnc_init_state, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 02/10] ui: remove 'enabled' and 'ws_enabled' fields from VncState, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 09/10] ui: rename vnc_init_state to vnc_start_protocol, Gerd Hoffmann, 2016/10/13
- Re: [Qemu-devel] [PULL 00/10] ui: vnc cleanups, input-linux kbd fix., Peter Maydell, 2016/10/13