[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] char: serial: check divider value against baud
|
From: |
P J P |
|
Subject: |
Re: [Qemu-devel] [PATCH] char: serial: check divider value against baud base |
|
Date: |
Wed, 12 Oct 2016 11:37:19 +0530 (IST) |
+-- On Tue, 11 Oct 2016, address@hidden wrote --+
| Your series seems to have some coding style problems.
| === OUTPUT BEGIN ===
| Checking PATCH 1/1: char: serial: check divider value against baud base...
| ERROR: braces {} are necessary for all arms of this statement
| #25: FILE: hw/char/serial.c:156:
| + if (s->divider == 0 || s->divider > s->baudbase)
| [...]
|
| Your patch has style problems, please review.
Ah sorry, I've sent a corrected patch v2.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F