qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] replication: interrupt failover if the main dev


From: Changlong Xie
Subject: Re: [Qemu-devel] [PATCH] replication: interrupt failover if the main device is closed
Date: Wed, 12 Oct 2016 13:02:51 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 10/07/2016 08:21 PM, Paolo Bonzini wrote:
Without this change, there is a race condition in tests/test-replication.
Depending on how fast the failover job (active commit) runs, there is a
chance of two bad things happening:

1) replication_done can be called after the secondary has been closed
and hence when the BDRVReplicationState is not valid anymore.

2) two copies of the active disk are present during the
/replication/secondary/stop test (that test runs immediately after
/replication/secondary/start, which tests failover).  This causes the
corruption detector to fire.

Signed-off-by: Paolo Bonzini <address@hidden>

Reviewed-by: Changlong Xie <address@hidden>

---
  block/replication.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/block/replication.c b/block/replication.c
index 3bd1cf1..5231a00 100644
--- a/block/replication.c
+++ b/block/replication.c
@@ -133,6 +133,9 @@ static void replication_close(BlockDriverState *bs)
      if (s->replication_state == BLOCK_REPLICATION_RUNNING) {
          replication_stop(s->rs, false, NULL);
      }
+    if (s->replication_state == BLOCK_REPLICATION_FAILOVER) {
+        block_job_cancel_sync(s->active_disk->bs->job);
+    }

      if (s->mode == REPLICATION_MODE_SECONDARY) {
          g_free(s->top_id);






reply via email to

[Prev in Thread] Current Thread [Next in Thread]