|
From: | Stefan Weil |
Subject: | Re: [Qemu-devel] [PATCH] net: eepro100: fix memory leak in device uninit |
Date: | Sat, 8 Oct 2016 18:19:13 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.2.0 |
Am 08.10.2016 um 14:07 schrieb Li Qiang:
From: Li Qiang <address@hidden> The exit dispatch of eepro100 network card device doesn't free the 's->vmstate' field which was allocated in device realize thus leading a host memory leak. This patch avoid this. Signed-off-by: Li Qiang <address@hidden>
Thank you for reporting this memory leak.I think that an even better solution would be avoiding the dynamic memory allocation. We could use this declaration for example:
/* vmstate for each particular nic */ VMStateDescription vmstate; Do you want to prepare a new patch, or should I do it? Regards Stefan
[Prev in Thread] | Current Thread | [Next in Thread] |