[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped address
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped addresses to apic |
Date: |
Sat, 8 Oct 2016 14:23:29 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Sat, Oct 08, 2016 at 02:14:09PM +0800, Peter Xu wrote:
> On Fri, Oct 07, 2016 at 06:24:15PM +0200, Radim Krčmář wrote:
>
> [...]
>
> > KVM accepts the address in host endianess and QEMU/VTD code also uses
> > host endianess for internal representation of memory addresses, so this
> > hunk should be fine.
> >
> > It is confusing, because the VTD is definitely broken with respect to
> > endianess -- it is even trying to swap the order of bits in a byte in
> > the definition of VTD_MSIMessage.
> > I don't believe that dma_memory_write() accepted LE address on BE hosts,
> > so the existing code for filling the address is wrong:
> >
> > msg.__addr_head = cpu_to_le32(0xfee);
>
> Yeah. This is my fault. Sorry for the troubles.
>
> I have a patch (as well...) to fix this in my local tree, but not
> posted (as mst suggested). Maybe it's time to post some of them now (I
> tried to make patches more into a bunch so that they won't be lost in
> mailing list in case maintainer missed it).
I'll send them after your series to avoid unecessary conflicts.
-- peterx
- Re: [Qemu-devel] [PATCH v4 2/8] apic: add send_msi() to APICCommonClass, (continued)
[Qemu-devel] [PATCH v4 1/8] apic: add global apic_get_class(), Radim Krčmář, 2016/10/05
[Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped addresses to apic, Radim Krčmář, 2016/10/05
Re: [Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped addresses to apic, Peter Xu, 2016/10/08
[Qemu-devel] [PATCH v4 4/8] intel_iommu: redo configuraton check in realize, Radim Krčmář, 2016/10/05
[Qemu-devel] [PATCH v4 6/8] intel_iommu: reject broken EIM, Radim Krčmář, 2016/10/05
[Qemu-devel] [PATCH v4 5/8] intel_iommu: add OnOffAuto intr_eim as "eim" property, Radim Krčmář, 2016/10/05