[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 04/11] qapi: add assert about root value
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL v2 04/11] qapi: add assert about root value |
Date: |
Fri, 7 Oct 2016 20:16:15 +0200 |
From: Marc-André Lureau <address@hidden>
qiv->root should not be null, make that clearer with some assert.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
qapi/qmp-input-visitor.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c
index fc91e74..c7deca9 100644
--- a/qapi/qmp-input-visitor.c
+++ b/qapi/qmp-input-visitor.c
@@ -64,6 +64,7 @@ static QObject *qmp_input_get_object(QmpInputVisitor *qiv,
if (QSLIST_EMPTY(&qiv->stack)) {
/* Starting at root, name is ignored. */
+ assert(qiv->root);
return qiv->root;
}
@@ -395,6 +396,7 @@ Visitor *qmp_input_visitor_new(QObject *obj, bool strict)
{
QmpInputVisitor *v;
+ assert(obj);
v = g_malloc0(sizeof(*v));
v->visitor.type = VISITOR_INPUT;
--
2.5.5
- [Qemu-devel] [PULL v2 00/11] QAPI patches for 2016-10-07, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL v2 04/11] qapi: add assert about root value,
Markus Armbruster <=
- [Qemu-devel] [PULL v2 10/11] docs: Belatedly update for move of qmp-commands.txt, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL v2 11/11] docs: Belatedly update for move of QMP/* to docs/, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL v2 03/11] tests/test-qmp-input-strict: Cover missing struct members, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL v2 06/11] qapi: return a 'missing parameter' error, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL v2 05/11] qapi: assert list entry has a value, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL v2 01/11] qmp: fix object-add assert() without props, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL v2 09/11] qmp: Disable query-cpu-* commands when they're unavailable, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL v2 07/11] MAINTAINERS: Pass the HMP staff from Luiz to David, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL v2 08/11] MAINTAINERS: Pass the QObject staff from Luiz to Markus, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL v2 02/11] qapi: Fix crash when 'any' or 'null' parameter is missing, Markus Armbruster, 2016/10/07