[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/20] Tracing patches
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 00/20] Tracing patches |
Date: |
Fri, 7 Oct 2016 15:16:16 +0100 |
On 7 October 2016 at 14:46, Lluís Vilanova <address@hidden> wrote:
> diff --git a/qom/cpu.c b/qom/cpu.c
> index 484c493..40f2eb1 100644
> --- a/qom/cpu.c
> +++ b/qom/cpu.c
> @@ -356,12 +356,15 @@ static void cpu_common_initfn(Object *obj)
> qemu_mutex_init(&cpu->work_mutex);
> QTAILQ_INIT(&cpu->breakpoints);
> QTAILQ_INIT(&cpu->watchpoints);
> - bitmap_zero(cpu->trace_dstate, TRACE_VCPU_EVENT_COUNT);
> +
> + cpu->trace_dstate = bitmap_new(min(trace_get_vcpu_event_count(), 1);
> }
>
> static void cpu_common_finalize(Object *obj)
> {
> - cpu_exec_exit(CPU(obj));
> + CPUState *cpu = CPU(obj);
> + cpu_exec_exit(cpu);
> + g_free(cpu->trace_dstate);
> }
>
> static int64_t cpu_common_get_arch_id(CPUState *cpu)
>
> Beware that min() needs to be defined somewhere on that file first (should it
> be
> available on some generic header?).
osdep.h defines a MIN() macro.
thanks
-- PMM
- [Qemu-devel] [PULL 14/20] trace: dynamically allocate event IDs at runtime, (continued)
- [Qemu-devel] [PULL 14/20] trace: dynamically allocate event IDs at runtime, Stefan Hajnoczi, 2016/10/07
- [Qemu-devel] [PULL 16/20] trace: rename _read_events to read_events, Stefan Hajnoczi, 2016/10/07
- [Qemu-devel] [PULL 15/20] trace: get rid of generated-events.h/generated-events.c, Stefan Hajnoczi, 2016/10/07
- [Qemu-devel] [PULL 17/20] trace: push reading of events up a level to tracetool main, Stefan Hajnoczi, 2016/10/07
- [Qemu-devel] [PULL 18/20] trace: pass trace-events to tracetool as a positional param, Stefan Hajnoczi, 2016/10/07
- [Qemu-devel] [PULL 19/20] trace: introduce a formal group name for trace events, Stefan Hajnoczi, 2016/10/07
- [Qemu-devel] [PULL 20/20] trace: Add missing execution mode of guest events, Stefan Hajnoczi, 2016/10/07
- Re: [Qemu-devel] [PULL 00/20] Tracing patches, Peter Maydell, 2016/10/07