Re: [Qemu-devel] [PATCH v6 21/20] linux-user/bsd-user: initialize trace events subsystem

[Daniel P. Berrange]

Just Cc'ing Stefan this time

On Fri, Oct 07, 2016 at 02:51:17PM +0100, Daniel P. Berrange wrote:
> The bsd-user/linux-user programs make use of the CPU emulation
> code and this now requires that the trace events subsystem
> is enabled, otherwise it'll crash trying to allocate an empty
> trace events bitmap for the CPU object.
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> 
> Stefan, technically this patch ought to be squashed into:
> 
>    [PATCH v6 13/20] trace: provide mechanism for registering trace events
> 
>  bsd-user/main.c   | 1 +
>  linux-user/main.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/bsd-user/main.c b/bsd-user/main.c
> index d803d3e..90d5bbd 100644
> --- a/bsd-user/main.c
> +++ b/bsd-user/main.c
> @@ -730,6 +730,7 @@ int main(int argc, char **argv)
>      if (argc <= 1)
>          usage();
>  
> +    module_call_init(MODULE_INIT_TRACE);
>      qemu_init_cpu_list();
>      module_call_init(MODULE_INIT_QOM);
>  
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 9e4b430..0e31dad 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -4158,6 +4158,7 @@ int main(int argc, char **argv, char **envp)
>      int ret;
>      int execfd;
>  
> +    module_call_init(MODULE_INIT_TRACE);
>      qemu_init_cpu_list();
>      module_call_init(MODULE_INIT_QOM);
>  
> -- 
> 2.7.4
> 

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|