[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init() |
Date: |
Fri, 7 Oct 2016 13:31:10 +0100 |
On 7 October 2016 at 13:27, Greg Kurz <address@hidden> wrote:
> Indeed but my suggestion is to open code this in qvirtio_is_big_endian(),
> and even rename QTestState::big_endian to virtio_big_endian to make it
> really obvious it should not be used elsewhere.
>
> I now remember this is what I was resolutely suggested to do in
> include/qom/cpu.h at the time we started to support ppc64le:
>
> bool (*virtio_is_big_endian)(CPUState *cpu);
Not really the same thing though -- virtio_is_big_endian
in QEMU is indeed used only in virtio, because it makes
dubious use of the internals of the CPU state. The
equivalent of this proposed qtest function is the #define
TARGET_BIG_ENDIAN, which is global to all of QEMU and
reasonably widely used (because it's not a property of
the CPU's internals).
thanks
-- PMM
- [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), Laurent Vivier, 2016/10/07
- Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), Greg Kurz, 2016/10/07
- Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), Laurent Vivier, 2016/10/07
- Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), Greg Kurz, 2016/10/07
- Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(),
Peter Maydell <=
- Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), Greg Kurz, 2016/10/07
- Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), Peter Maydell, 2016/10/07
- Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), Laurent Vivier, 2016/10/07
- Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), Greg Kurz, 2016/10/07
Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), David Gibson, 2016/10/10
- Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), Peter Maydell, 2016/10/10
- Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), David Gibson, 2016/10/10
- Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), Peter Maydell, 2016/10/10
- Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), David Gibson, 2016/10/10
- Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init(), David Gibson, 2016/10/11