[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 10/12] qmp: Disable query-cpu-* commands when they're
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 10/12] qmp: Disable query-cpu-* commands when they're unavailable |
Date: |
Fri, 7 Oct 2016 14:09:17 +0200 |
From: Eduardo Habkost <address@hidden>
Instead of requiring clients to actually call the query-cpu-*
commands to find out if they are implemented, remove them from
the output of "query-commands", so clients know they are not
available.
This is implemented by extending the existing hack at
qmp_unregister_commands_hack(). I wish I could avoid adding even
more #ifdefs to that code, but that's the solution we have today.
Signed-off-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
monitor.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/monitor.c b/monitor.c
index 83c4edf..4ff74b7 100644
--- a/monitor.c
+++ b/monitor.c
@@ -992,6 +992,15 @@ static void qmp_unregister_commands_hack(void)
#ifndef TARGET_ARM
qmp_unregister_command("query-gic-capabilities");
#endif
+#if !defined(TARGET_S390X)
+ qmp_unregister_command("query-cpu-model-expansion");
+ qmp_unregister_command("query-cpu-model-baseline");
+ qmp_unregister_command("query-cpu-model-comparison");
+#endif
+#if !defined(TARGET_PPC) && !defined(TARGET_ARM) && !defined(TARGET_I386) \
+ && !defined(TARGET_S390X)
+ qmp_unregister_command("query-cpu-definitions");
+#endif
}
static void qmp_init_marshal(void)
--
2.5.5
- [Qemu-devel] [PULL 00/12] QAPI patches for 2016-10-07, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL 06/12] qapi: assert list entry has a value, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL 05/12] qapi: add assert about root value, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL 09/12] MAINTAINERS: Pass the QObject staff from Luiz to Markus, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL 02/12] qapi: Fix crash when 'any' or 'null' parameter is missing, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL 12/12] docs: Belatedly update for move of QMP/* to docs/, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL 04/12] tests: start generic qemu-qmp tests, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL 03/12] tests/test-qmp-input-strict: Cover missing struct members, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL 10/12] qmp: Disable query-cpu-* commands when they're unavailable,
Markus Armbruster <=
- [Qemu-devel] [PULL 01/12] qmp: fix object-add assert() without props, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL 07/12] qapi: return a 'missing parameter' error, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL 11/12] docs: Belatedly update for move of qmp-commands.txt, Markus Armbruster, 2016/10/07
- [Qemu-devel] [PULL 08/12] MAINTAINERS: Pass the HMP staff from Luiz to David, Markus Armbruster, 2016/10/07
- Re: [Qemu-devel] [PULL 00/12] QAPI patches for 2016-10-07, Peter Maydell, 2016/10/07