[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-arm: kvm: use AddressSpace-specific list
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] target-arm: kvm: use AddressSpace-specific listener |
Date: |
Thu, 6 Oct 2016 17:02:43 +0100 |
On 30 September 2016 at 08:17, Paolo Bonzini <address@hidden> wrote:
> The only address space where the GIC devices are added is
> address_space_memory. There is no need to use a global
> MemoryListener.
>
> This removes the only user of global MemoryListeners.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> target-arm/kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-arm/kvm.c b/target-arm/kvm.c
> index dbe393c..41f2038 100644
> --- a/target-arm/kvm.c
> +++ b/target-arm/kvm.c
> @@ -283,7 +283,7 @@ void kvm_arm_register_device(MemoryRegion *mr, uint64_t
> devid, uint64_t group,
> }
>
> if (QSLIST_EMPTY(&kvm_devices_head)) {
> - memory_listener_register(&devlistener, NULL);
> + memory_listener_register(&devlistener, &address_space_memory);
> qemu_add_machine_init_done_notifier(¬ify);
> }
> kd = g_new0(KVMDevice, 1);
Reviewed-by: Peter Maydell <address@hidden>
The code effectively assumes there's only one address
space the devices will live in anyway...
thanks
-- PMM
- Re: [Qemu-devel] [PATCH] target-arm: kvm: use AddressSpace-specific listener,
Peter Maydell <=