|
From: | Cao jin |
Subject: | Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error |
Date: | Thu, 6 Oct 2016 15:00:10 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 09/30/2016 10:06 PM, Markus Armbruster wrote:
Alex Williamson <address@hidden> writes:
Once there's a need to handle a certain condition as an error, we should do that, no argument. This also provides a way to test the error path. However, I wouldn't buy an argument that preconditions should be made as weak as possible in leaf functions (let alone always) regardless of the cost in complexity, and non-testability of error paths. I'm strictly a pay as you go person. Back to the problem at hand. Cao jin, would you be willing to fix msi_init()?
Sorry for the holiday delay. Sure, will fix it, and add it as a new patch in this series.
-- Yours Sincerely, Cao jin
[Prev in Thread] | Current Thread | [Next in Thread] |