[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 12/20] trace: don't abort qemu if ftrace can'
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v6 12/20] trace: don't abort qemu if ftrace can't be initialized |
Date: |
Wed, 5 Oct 2016 16:39:49 +0100 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Tue, Oct 04, 2016 at 03:12:31PM -0500, Eric Blake wrote:
> On 10/04/2016 08:35 AM, Daniel P. Berrange wrote:
> > If the ftrace backend is compiled into QEMU, any attempt
> > to start QEMU while non-root will fail due to the
> > inability to open /sys/kernel/debug/tracing/tracing_on.
> >
> > Add a fallback into the code so that it connects up the
> > trace_marker_fd variable to /dev/null when setting
>
> s/setting/getting/ ?
>
> > EACCESS on the 'trace_on' file. This allows QEMU to
>
> s/EACCESS/EACCES/
Thanks, I've applied these changes while merging.
Stefan
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v6 01/20] trace: move colo trace events to net/ sub-directory, (continued)
- [Qemu-devel] [PATCH v6 01/20] trace: move colo trace events to net/ sub-directory, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 03/20] trace: add trace event iterator APIs, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 05/20] trace: remove some now unused functions, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 06/20] trace: remove global 'uint16 dstate[]' array, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 07/20] trace: remove duplicate control.h includes in generated-tracers.h, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 08/20] trace: break circular dependency in event-internal.h, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 09/20] trace: give each trace event a named TraceEvent struct, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 10/20] trace: remove the TraceEventID and TraceEventVCPUID enums, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 12/20] trace: don't abort qemu if ftrace can't be initialized, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 13/20] trace: provide mechanism for registering trace events, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 11/20] trace: emit name <-> ID mapping in simpletrace header, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 14/20] trace: dynamically allocate trace_dstate in CPUState, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 15/20] trace: dynamically allocate event IDs at runtime, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 16/20] trace: get rid of generated-events.h/generated-events.c, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 17/20] trace: rename _read_events to read_events, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 19/20] trace: pass trace-events to tracetool as a positional param, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 18/20] trace: push reading of events up a level to tracetool main, Daniel P. Berrange, 2016/10/04
- [Qemu-devel] [PATCH v6 20/20] trace: introduce a formal group name for trace events, Daniel P. Berrange, 2016/10/04